cln-rpc: purge msats and encode amounts as u64#9275
Draft
daywalker90 wants to merge 1 commit into
Draft
Conversation
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
99ca019 to
ff31879
Compare
daywalker90
added
the
Status::Ready for Review
nepet
approved these changes
Jul 3, 2026
Drop conversion to string and instead implement Display Changelog-None
daywalker90
force-pushed
the
cln-rpc-msat-purge
branch
from
ff31879 to
128710c
Compare
Collaborator
Author
|
CI found an integration test that fails with this change: So i fixed: test_lsps2_buyjitchannel_mpp_fixed_invoice
- amount_msat=f"{amt}msat",
+ amount_msat=amt,This tests is quite new and i hope on the other end no one is using msat suffixes anymore?! |
daywalker90
removed
the
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop conversion to string and instead implement Display
Changelog-None